Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

Add support for sending Uint8Array objects #554

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ameily
Copy link

@ameily ameily commented Aug 24, 2016

I added support for sending Uint8Array objects over a zmq socket. The problem was that zmq was wrapping the Uint8Array object in a Buffer before sending the object out.

@ronkorving
Copy link
Collaborator

Hi @ameily, thanks for the contribution.
Does the handling of that Uint8Array in C++ land work?

@ameily
Copy link
Author

ameily commented Aug 25, 2016

I'm not entirely sure how Node implementes the Uint8Arrayclass in native code. However, I've verified that this PR works and the zmq library properly handles Uint8Array. I'm using flatbuffers, which is a binary protocol that uses Uint8Arrayobjects and everything seems to work fine on both the sending and receiving ends.

@crostagnol
Copy link

Thanks @ameily for this contribution! It was very helpful for my project.
I'm also using flatbuffers over ZMQ.
It would be great if this commit is merged into the master branch for next release ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants