Add signal to indicate destruction of Object

The 'destroyed' signal is emitted when Object::~Object is called before any of the Object's children are destroyed. Change-Id: Ida5783cc515d28efc75d7d9a060b1b3aea4e4cea Reviewed-on: https://codereview.kdab.com/c/kdab/kdutils/+/135487 Reviewed-by: Paul Lemire <[email protected]> Tested-by: Continuous Integration <[email protected]> Reviewed-by: Miłosz Kosobucki <[email protected]>
KDAB · Dec 20, 2023 · 8cdc640 · 8cdc640
1 parent 662918f
commit 8cdc640
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/src/KDFoundation/object.cpp b/src/KDFoundation/object.cpp
@@ -25,6 +25,8 @@ Object::Object()
 
 Object::~Object()
 {
+    destroyed.emit(this);
+
     // Destroy the children in LIFO to be more like the stack
     while (!m_children.empty()) {
         childRemoved.emit(this, m_children.back().get());

diff --git a/src/KDFoundation/object.h b/src/KDFoundation/object.h
@@ -97,6 +97,7 @@ class KDFOUNDATION_API Object : public EventReceiver
     KDBindings::Signal<Object *, Object *> parentChanged;
     KDBindings::Signal<Object *, Object *> childAdded;
     KDBindings::Signal<Object *, Object *> childRemoved;
+    KDBindings::Signal<Object *> destroyed;
 
 protected:
     virtual void timerEvent(TimerEvent *ev);

diff --git a/tests/auto/foundation/object/tst_object.cpp b/tests/auto/foundation/object/tst_object.cpp
@@ -290,6 +290,14 @@ TEST_CASE("Object destruction")
             REQUIRE(expectedDestructionOrder[i] == destructionOrder[i]);
         }
     }
+
+    SUBCASE("destroyed signal is emitted on object destruction")
+    {
+        auto obj = new Object();
+        SignalSpy objectDestroyedSpy(obj->destroyed);
+        delete obj;
+        REQUIRE(objectDestroyedSpy.count() == 1);
+    }
 }
 
 TEST_CASE("Event delivery")