Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TextLocation and TextRange class #108

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

narnaud
Copy link
Member

@narnaud narnaud commented Jul 15, 2024

Replaced with the existing MarkRange.

The rename, if any, is left out and will be part of #54.

Fix #67

Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the change to the VS Code Workspace file this looks good 👍

knut.code-workspace Outdated Show resolved Hide resolved
Replace with the existing RangeMark.

Related-to KDAB#67
Replaced with the existing MarkRange.

Fix KDAB#67
@narnaud narnaud merged commit aa41a17 into KDAB:main Jul 16, 2024
5 checks passed
@narnaud narnaud deleted the cleanup-cursors branch July 16, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the text range/mark API
2 participants