Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/query dsl 도입 및 적용하기 #433

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

sososo0
Copy link
Collaborator

@sososo0 sososo0 commented Mar 19, 2024

🔥 Related Issue

close: # 269

📝 Description

수행한 작업을 설명해주세요.

Query DSL을 적용하기 위한 설정을 추가했습니다.
일부 Repository의 문자열로 된 query를 Query DSL로 변경하는 작업을 하였습니다.
모든 Repository를 다 변경한 것이 아니라서, 관심 있으신 분들 이어 받아서 작업하시면 될 것 같습니다!

⭐️ Review Request

리뷰어에게 전달하고 싶은 내용을 적어주세요.

쿼리를 맞게 수정했는지 꼼꼼하게 확인 부탁드립니다!
쿼리 테스트를 어떻게 하는게 좋을지 고민을 많이 해봤는데, 아직 경험이 없어 잘 모르겠습니다! 추천이나 조언 환영합니다 😄
혹시라도 작동이 안되거나 이 부분이 좀 이상하다!! 싶으면 언제든지 말씀해주세요~!

@sososo0 sososo0 added the 🛠️ refactor 코드 리팩토링 (기능 변경 X) label Mar 19, 2024
@sososo0 sososo0 self-assigned this Mar 19, 2024
Copy link
Collaborator

@02ggang9 02ggang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리팩토링 수고하셨습니다~~!


private final JPAQueryFactory jpaQueryFactory;

@Modifying
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 어노테이션은 어떤 역할을 하나요?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조회를 제외한 쿼리를 직접 작성할 경우에 붙여줘야 하는 걸로 압니다! (맞나용?)

Copy link
Collaborator

@JJimini JJimini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

Copy link
Contributor

@shkisme shkisme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!! QueryDSL 드디어 적용... ㅎㅎ👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gradlew, gradlew.bat 파일들이 올라갔는데 의도하신 건지 궁금합니당!


private final JPAQueryFactory jpaQueryFactory;

@Modifying
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조회를 제외한 쿼리를 직접 작성할 경우에 붙여줘야 하는 걸로 압니다! (맞나용?)

@gusah009 gusah009 assigned 02ggang9 and unassigned sososo0 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ refactor 코드 리팩토링 (기능 변경 X)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants