[UI/#7] 리듬뷰 / UI 구현 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chattymin
approved these changes
Jul 23, 2024
Comment on lines
+64
to
+68
| android:background="@{vm.rhythmLevel == 1 ? @drawable/shape_purple50_fill_circle : @drawable/shape_gray200_fill_circle}" | ||
| android:gravity="center" | ||
| android:onClick="@{() -> vm.changeRhythmLevel(1)}" | ||
| android:text="1" | ||
| android:textColor="@{vm.rhythmLevel == 1 ? @color/white : @color/gray_700}" /> |
There was a problem hiding this comment.
이 부분은 아래에서 많이 중복되고 있는 것 같은데 오히려 viewBinding으로 하는건 어땠을까요??
There was a problem hiding this comment.
저도 하고나서 고민했지만 귀찮아서 그냥 냅다 밀고가기로 했습니다
ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ
조만간 거슬려서 사라질 예정입니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
KakaoTalk_Video_2024-07-23-23-49-55.mp4
📢 To Reviewers