fix(client): item bopping bug

Kaetram · Jul 18, 2023 · ebaaff4 · ebaaff4
1 parent f80d5f1
commit ebaaff4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/packages/client/src/entity/entity.ts b/packages/client/src/entity/entity.ts
@@ -38,6 +38,7 @@ export default abstract class Entity {
 
     public animation!: Animation | null;
 
+    public offsetY = 0; // Used for manually offsetting the entity itself.
     public shadowOffsetY = 0;
     public hidden = false;
 

diff --git a/packages/client/src/entity/objects/item.ts b/packages/client/src/entity/objects/item.ts
@@ -36,7 +36,7 @@ export default class Item extends Entity {
 
         // We use the `onBop` callback to update the sprite's offset.
         this.animation?.onBop((bopIndex: number) => {
-            this.sprite.offsetY = this.originalY - bopIndex;
+            this.offsetY = this.originalY - bopIndex;
         });
     }
 

diff --git a/packages/client/src/renderer/renderer.ts b/packages/client/src/renderer/renderer.ts
@@ -667,7 +667,7 @@ export default class Renderer {
             entity.sprite.width,
             entity.sprite.height,
             entity.sprite.offsetX,
-            entity.sprite.offsetY,
+            entity.sprite.offsetY + entity.offsetY,
             entity.sprite.width,
             entity.sprite.height
         );