chore(pds-popover): update function names to not duplicate

Kajabi · Feb 27, 2024 · a04782e · a04782e
1 parent 31e747c
commit a04782e
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 13 deletions.
diff --git a/libs/core/src/components.d.ts b/libs/core/src/components.d.ts
@@ -450,7 +450,7 @@ export namespace Components {
         /**
           * Hides the popover by disabling the opened property
          */
-        "hidePopover": () => Promise<void>;
+        "hidePdsPopover": () => Promise<void>;
         /**
           * Determines whether or not the popover is visible
           * @defaultValue false

diff --git a/libs/core/src/components/pds-popover/pds-popover.tsx b/libs/core/src/components/pds-popover/pds-popover.tsx
@@ -68,7 +68,7 @@ export class PdsPopover {
 
   componentDidUpdate() {
     if (this.opened) {
-      this.showPopover();
+      this.showPdsPopover();
     }
   }
 
@@ -102,17 +102,17 @@ export class PdsPopover {
    * Hides the popover by disabling the opened property
    */
   @Method()
-  async hidePopover() {
+  async hidePdsPopover() {
     this.opened = false;
   }
 
   private handleHide = () => {
-    this.hidePopover();
+    this.hidePdsPopover();
     this.pdsPopoverHide.emit();
   };
 
   private handleShow = () => {
-    this.showPopover();
+    this.showPdsPopover();
     this.pdsPopoverShow.emit();
   };
 
@@ -147,7 +147,7 @@ export class PdsPopover {
           <span
             aria-describedby={this.componentId}
             class="pds-popover__trigger"
-            onClick={() => this.togglePopover()}
+            onClick={() => this.togglePdsPopover()}
           >
             <slot />
           </span>

diff --git a/libs/core/src/components/pds-popover/readme.md b/libs/core/src/components/pds-popover/readme.md
@@ -25,7 +25,7 @@
 
 ## Methods
 
-### `hidePopover() => Promise<void>`
+### `hidePdsPopover() => Promise<void>`
 
 Hides the popover by disabling the opened property
 

diff --git a/libs/core/src/components/pds-popover/test/pds-popover.spec.tsx b/libs/core/src/components/pds-popover/test/pds-popover.spec.tsx
@@ -47,16 +47,16 @@ describe('pds-popover', () => {
     // Initially, the opened property should be false
     expect(popover.opened).toBe(false);
 
-    // Call the togglePopover method
-    await popover.togglePopover();
+    // Call the togglePdsPopover method
+    await popover.togglePdsPopover();
 
-    // After calling togglePopover, the opened property should be true
+    // After calling togglePdsPopover, the opened property should be true
     expect(popover.opened).toBe(true);
 
-    // Call the togglePopover method again
-    await popover.togglePopover();
+    // Call the togglePdsPopover method again
+    await popover.togglePdsPopover();
 
-    // After calling togglePopover again, the opened property should be false
+    // After calling togglePdsPopover again, the opened property should be false
     expect(popover.opened).toBe(false);
   });