Revert HW accel due to video memory leak #6
+2
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarbat
approved these changes
Jun 22, 2018
wizofe
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would seem that the new hardware acceleration options on the QML Canvas introduced the memory leak we were seeing with @skarbat 's automation script.
Setups:
CKC + 22nd rc + qmlmatrix v4.0: NO kernel crashes using his test_ssaver_loop.sh, but showing mem leak
CKC + 17th devel + qmlmatrix v1 + audio_pwm_mode=1: NO kernel crashes using his test_ssaver_loop.sh and no mem leak
Requires:
KanoComputing/kano-settings#511
KanoComputing/kano-updater#324