feat #734: Delete a node using the delete key

[ibek]

also for #1477

[codecov]

Codecov Report

Attention: Patch coverage is 67.50000% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@d985f82). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
.../ui/src/components/Visualization/Canvas/Canvas.tsx	45.83%	11 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1566   +/-   ##
=======================================
  Coverage        ?   79.87%           
  Complexity      ?      272           
=======================================
  Files           ?      277           
  Lines           ?     7910           
  Branches        ?     1553           
=======================================
  Hits            ?     6318           
  Misses          ?     1481           
  Partials        ?      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[apupier]

• When trying to delete a route, it is asking if we want to delete a step and the deletion is not working
• i think this is an important feature which requires tests to avoid regression and to be sure that we do not delete more data than planned
• i'm wondering if the code could not be factorized with the delete from the contextual menu
• recommendation to link the PR to the issue in github, the commi tmessage should include the text fixes #734

[apupier]

it will be better to split the 2 features delete and move. As there are several feedback on them which are independent.

• About delete:
  • I still really think it is very important having tests for the delete functionality as it can lead to data loss if there is a problem
• About keys to navigate:
  • By default, the layout is top-down and not left-right, here it is using left/right arrow to move in the route. arrow up/down would be more natural as the default. In another iteration, we can make it dependent on the layout direction.
  • When at the end of the route, I would expect to stay on the last step when moving with key (or moving up, so selecting route). But can be done in another iteration. it would also ensures to not get out of the navigation.
  • When inside a container on latest element and using key to go to next element, selection is removed. i would expect to go to next element outside of the container
  • I see a lot of little corner case with arrows to navigate selection so would be better to have tests in place. (for instance when there will be multi-selection possible)

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud