fix(build): Fix sass-related deprecation notice #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaoto uses `vite` for bundling the project in dev mode using the `legacy` sass API. With the upcoming `sass` 2.0, some APIs were marked for removal and shows warnings in the meantime. This commit follows the [vite docs](https://vite.dev/config/shared-options#css-preprocessoroptions) and sets the css preprocessor config to `modern-compiler`, in addition to that, replaces the `sass` package with `sass-embedded`
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1578 +/- ##
=======================================
Coverage ? 80.09%
Complexity ? 272
=======================================
Files ? 278
Lines ? 7882
Branches ? 1542
=======================================
Hits ? 6313
Misses ? 1460
Partials ? 109 ☔ View full report in Codecov by Sentry. |
igarashitm
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Kaoto uses
viteto bundle the project in dev mode using thelegacysass API.With the upcoming
sass2.0, some APIs were marked for removal and show warnings.This commit follows the vite
docs and sets the css preprocessor config to
modern-compiler, in addition to that, replaces thesasspackage withsass-embedded