Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rack v1: plugin.json and slug need update #9

Open
cschol opened this issue Jun 3, 2019 · 1 comment
Open

Rack v1: plugin.json and slug need update #9

cschol opened this issue Jun 3, 2019 · 1 comment

Comments

@cschol
Copy link
Contributor

cschol commented Jun 3, 2019

A few issues that need fixing in the v1 branch:

  1. sourceUrl should be https://github.com/KarateSnoopy/vcv-karatesnoopy.git (incl. the .git)
  2. pluginUrl and manualUrl should point to the README.md of your repository.
  3. The slug for the 2D grid sequencer has to adhere to the v1 naming conventions, i.e. it cannot contain whitespace characters. Now, since this has been the slug used in v0.6 for your plugin, you should create the slug as follows: KSnpy2DGridSeq. Rack v1 will ensure backwards compatibility for pre-v1 patches by normalizing the module name on loading the patch, i.e. removing invalid characters. Note, that you also need to update the slug in Seq.cpp.
@KarateSnoopy
Copy link
Owner

Thanks @cschol . Fixed in 4168a22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants