Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Darker" theme to book reader, i.e. the dark theme with gray text to reduce contrast while reading in the dark. #3087

Closed
wants to merge 5 commits into from

Conversation

RPLgrime
Copy link

Added

  • Added: Book Reader specific theme called 'Darker'.
  • Added: New Translation Key for 'theme-darker' in order for UI to translate correctly to users.

Changed

  • Changed: Number of Book Reader built-in themes from (4) to (5). The UI array auto-updates the amount of swatches a user can choose from within the Book Reader drawer.

…xt to provide less contrast while reading in the dark.
@RPLgrime
Copy link
Author

I don't mind changing the descriptor 'Darker', but I thought it would stack decently between 'Dark' and 'Black'.
Below is a screenshot of the Book Reader drawer with extra Color Theme swatch.

image

@RPLgrime
Copy link
Author

RPLgrime commented Aug 6, 2024

I have a large library and Compact Numbers truncates quite a bit for me, so I thought it would be nice to give users a quick toggle to see their data in both ways. I preserved the Kavita intent by defaulting to Compact Numbers = true.

@majora2007
Copy link
Member

I took a brief look at this and the color contrast was pretty bad, so much that me merging it opens me to having to fix it, which defeats the purpose.

Instead, I'd be open if you'd want to try and modify the currently open fonts PR and try to extend it for Book reader themes? This way anyone can have any theme they want for the epub reader.

@majora2007 majora2007 closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants