Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-543: add parsing CollapsingToolbarLayout title + sample #544

Conversation

mfglushchenko
Copy link
Collaborator

  • add CollapsingToolbarLayout titles to the list of localized strings
  • add sample screen and test

@@ -61,7 +62,25 @@ internal class ActivityMetadata(
v.width,
v.height
)
}.toMutableList()

val stringsFromToolbarLayouts = TreeIterables.depthFirstViewTraversal(decorView)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid traversing the hierarchy twice? For example:
TreeIterables.depthFirstViewTraversal(decorView)
.filter { it.visibility == View.VISIBLE }
.filter( it is TextView || it is CollapsingToolbarLayout)
.map { case for TextView and CollapsingToolbarLayout } ...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@AzamatCherchesov
Copy link
Collaborator

Some problems with detekt. @mfglushchenko have a look pls

@mfglushchenko mfglushchenko merged commit 4abeb32 into master Aug 1, 2023
5 checks passed
@AzamatCherchesov AzamatCherchesov deleted the ISSUE-543-toolbar-layout-missing-title-in-screenshot-metadata branch September 7, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CollapsingToolbarLayout title missing in screenshot tests
2 participants