ISSUE-543: add parsing CollapsingToolbarLayout title + sample #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mfglushchenko
commented
Jul 18, 2023
mfglushchenko
commented
- add CollapsingToolbarLayout titles to the list of localized strings
- add sample screen and test
mfglushchenko
requested review from
matzuk,
AzamatCherchesov,
eakurnikov,
RuslanMingaliev and
Nikitae57
as code owners
| @@ -61,7 +62,25 @@ internal class ActivityMetadata( | |||
| v.width, | |||
| v.height | |||
| ) | |||
| }.toMutableList() | |||
|
|
|||
| val stringsFromToolbarLayouts = TreeIterables.depthFirstViewTraversal(decorView) | |||
There was a problem hiding this comment.
Can we avoid traversing the hierarchy twice? For example:
TreeIterables.depthFirstViewTraversal(decorView)
.filter { it.visibility == View.VISIBLE }
.filter( it is TextView || it is CollapsingToolbarLayout)
.map { case for TextView and CollapsingToolbarLayout } ...
AzamatCherchesov
previously approved these changes
Jul 24, 2023
|
Some problems with detekt. @mfglushchenko have a look pls |
…screenshot-metadata
…screenshot-metadata
…tadata' of https://github.com/KasperskyLab/Kaspresso into ISSUE-543-toolbar-layout-missing-title-in-screenshot-metadata
AzamatCherchesov
approved these changes
Aug 1, 2023
AzamatCherchesov
deleted the
ISSUE-543-toolbar-layout-missing-title-in-screenshot-metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.