ISSUE-656: add flag to remove PermissionController #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OvsyannikovMaksim
requested review from
matzuk,
AzamatCherchesov,
eakurnikov,
RuslanMingaliev and
Nikitae57
as code owners
Nikitae57
requested changes
Aug 15, 2024
...resso/src/main/kotlin/com/kaspersky/kaspresso/systemsafety/SystemDialogSafetyProviderImpl.kt
Outdated
Show resolved
Hide resolved
Nikitae57
previously approved these changes
Aug 20, 2024
CherchesovAzamat
previously approved these changes
Aug 20, 2024
OvsyannikovMaksim
dismissed stale reviews from CherchesovAzamat and Nikitae57
via
9dc0052
CherchesovAzamat
approved these changes
Oct 27, 2024
| @@ -111,7 +111,12 @@ class SystemDialogSafetyProviderImpl( | |||
| */ | |||
| private fun isAndroidSystemDetected(): Boolean { | |||
| with(uiDevice) { | |||
| var isSystemDialogVisible = SystemDialogSafetyPattern.values().any { isVisible(By.pkg(it.pattern).clazz(FrameLayout::class.java)) } | |||
| var isSystemDialogVisible = if (systemDialogsSafetyParams.shouldIgnorePermissionDialogs) { | |||
| SystemDialogSafetyPattern.values().filter { it != SystemDialogSafetyPattern.PERMISSION_API30 && it != SystemDialogSafetyPattern.PERMISSION_API23 } | |||
There was a problem hiding this comment.
maybe it is a mistake?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.