Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/opt out of rendering #22

Merged
merged 12 commits into from
May 20, 2024
Merged

Fix/opt out of rendering #22

merged 12 commits into from
May 20, 2024

Conversation

bkapustik
Copy link
Collaborator

Motivation

Disable default rendering of tags in the Xperience administration pagebuilder and preview.
Add option to select rendering in pagebuilder or preview or both.

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@bkapustik bkapustik removed the request for review from seangwright May 15, 2024 11:19
@seangwright
Copy link
Member

@bkapustik it looks like all the suggestions I requested were reverted in the most recent commit. Can you fix this?

@michalJakubis michalJakubis merged commit 6d4549c into main May 20, 2024
1 check passed
@michalJakubis michalJakubis deleted the fix/opt-out-of-rendering branch May 20, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalJakubis michalJakubis michalJakubis approved these changes

@seangwright seangwright seangwright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkapustik @seangwright @michalJakubis