Fix QuillViewComponent formats issue #1877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There currently is an issue where if you have custom
formats
(I hadformats: ['link', 'size', 'italic', 'bold', 'list', 'header', 'underline', 'indent', 'align', 'color', 'image', 'strong'],
) configured in theQuillModule.forRoot()
method and you don't pass in customformats
to the view component. This throws the following runtime error when trying to render<quill-view />
:This is because the
formats
that's passed intoQuill
from theQuillViewComponent
component can be an object, as opposed to astring[]
, whenformats
passed into the component isundefined
(see line 143)My PR uses the same logic found in the editor component, which does have the correct implementation.