Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support full join for nested loop join #221

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

crwen
Copy link
Member

@crwen crwen commented Sep 8, 2024

What problem does this PR solve?

Issue link: #206

Add support for nested loop join

Some results does not mathe sql statements(e.g. column numbers, results order) in join.slt, so I changed some results or sql.
And some sql may have wrong syntax, so I remain them commented.

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

Copy link
Member

@KKould KKould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution

@KKould KKould merged commit 8351bd0 into KipData:main Sep 14, 2024
3 checks passed
@KKould KKould linked an issue Sep 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Support Full Join when HashJoin cannot be used
2 participants