Add Orient to Face Endpoint #612
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
=======================================
Coverage ? 25.73%
=======================================
Files ? 35
Lines ? 2063
Branches ? 0
=======================================
Hits ? 531
Misses ? 1532
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
added 6 commits
November 18, 2024 15:59
adamchalmers
approved these changes
Dec 13, 2024
| @@ -1134,6 +1134,22 @@ define_modeling_cmd_enum! { | |||
| pub animated: bool, | |||
| } | |||
|
|
|||
| /// Looks along the normal of the specified face (if it is planar!), and fits the view to it. | |||
There was a problem hiding this comment.
What happens if it's not planar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling of https://github.com/KittyCAD/engine/pull/2780