Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some colors and export file size changes occurred engine-side, update tests to match #3753

Merged
merged 20 commits into from
Sep 4, 2024

Conversation

franknoirot
Copy link
Collaborator

Started seeing electron playwright test failures on main today, all around the expected color values of models and expected export file sizes, and all failing in consistent ways. I take that to mean that these things shifted subtly somewhere upstream, so we can safely update the tests to account for that.

Copy link

qa-wolf bot commented Sep 3, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Sep 4, 2024 4:36am

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.56%. Comparing base (91d3ba3) to head (d39c5b6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3753   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files          65       65           
  Lines       25276    25276           
=======================================
  Hits        22133    22133           
  Misses       3143     3143           
Flag Coverage Δ
wasm-lib 87.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@Irev-Dev Irev-Dev merged commit 0eef6ab into main Sep 4, 2024
28 checks passed
@Irev-Dev Irev-Dev deleted the franknoirot/fix-electron-playwright branch September 4, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants