-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some colors and export file size changes occurred engine-side, update tests to match #3753
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3753 +/- ##
=======================================
Coverage 87.56% 87.56%
=======================================
Files 65 65
Lines 25276 25276
=======================================
Hits 22133 22133
Misses 3143 3143
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
|
|
|
|
|
|
|
Started seeing electron playwright test failures on main today, all around the expected color values of models and expected export file sizes, and all failing in consistent ways. I take that to mean that these things shifted subtly somewhere upstream, so we can safely update the tests to account for that.