-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ZOO_HOST not LOCAL_ENGINE_ADDR #4318
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
man i feel like that should be a util maybe ill make a pr becuase that code is copied everywher |
maybe we expose it to the world sincce i use the equivalent here too https://github.com/KittyCAD/kcl.py/blob/main/src/lib.rs#L185 |
ill make a pr |
@jessfraz OK feel free to close this one if you want |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4318 +/- ##
=======================================
Coverage 85.80% 85.80%
=======================================
Files 77 77
Lines 27189 27189
=======================================
Hits 23330 23330
Misses 3859 3859
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
okay i made it way more dry and external folks can now call these like now we can use these in kcl.py #4321 |
No description provided.