Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ZOO_HOST not LOCAL_ENGINE_ADDR #4318

Closed
wants to merge 1 commit into from

Conversation

adamchalmers
Copy link
Collaborator

No description provided.

Copy link

qa-wolf bot commented Oct 25, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Oct 25, 2024 11:00pm

@jessfraz
Copy link
Contributor

man i feel like that should be a util maybe ill make a pr becuase that code is copied everywher

@jessfraz
Copy link
Contributor

maybe we expose it to the world sincce i use the equivalent here too https://github.com/KittyCAD/kcl.py/blob/main/src/lib.rs#L185

@jessfraz
Copy link
Contributor

ill make a pr

@adamchalmers
Copy link
Collaborator Author

@jessfraz OK feel free to close this one if you want

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.80%. Comparing base (ca10211) to head (976d5d2).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/wasm-lib/kcl-test-server/src/lib.rs 0.00% 2 Missing ⚠️
src/wasm-lib/kcl/src/executor.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4318   +/-   ##
=======================================
  Coverage   85.80%   85.80%           
=======================================
  Files          77       77           
  Lines       27189    27189           
=======================================
  Hits        23330    23330           
  Misses       3859     3859           
Flag Coverage Δ
wasm-lib 85.80% <40.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz
Copy link
Contributor

okay i made it way more dry and external folks can now call these like now we can use these in kcl.py #4321

@jessfraz jessfraz closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants