-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KCL: Change core sketch functions to use keyword args #4826
base: main
Are you sure you want to change the base?
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1f6427d
to
a61d547
Compare
68b00f2
to
5f6057f
Compare
92360e7
to
f240bbb
Compare
I skimmed this and it looks great so far. Does it maintain backward compatibility? If not, the UI needs to generate the new code. |
d66bbce
to
356b257
Compare
101bd66
to
b686ca2
Compare
41e05c9
to
e99f814
Compare
4e8305d
to
f678077
Compare
ab661f4
to
398afe7
Compare
It doesn't, you're right, I need to update frontend. |
0a0826d
to
163ffea
Compare
Changes to KCL stdlib:
line(point, sketch, tag)
andlineTo(point, sketch, tag)
are combined intoline(@sketch, end?, endAbsolute?, tag?)
close(sketch, tag?)
is nowclose(@sketch, tag?)
extrude(length, sketch)
is nowextrude(@sketch, length)
Incidental changes:
#[stdlib]
proc-macro inderive-docs
) now use docs.rs/miette to show a beautiful error.Here's a before:
And here's after: