feat(sia): extract sia lib to external repo #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamardy
previously approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Huge work @Alrighttt! Would it be fine by you to extract sia rust lib to a separate repo before merging this PR? I don't want to merge all this code to dev then remove a lot of it in another PR.
|
I created a sia integration tracking issue here #2201 with checklist for things so that we don't forget. |
5 tasks
|
Sia crate has now been moved to https://github.com/komodoplatform/sia-rust . This PR is ready to merge. |
|
Reverted this 9b015a5 here 4bdeb64 as requested by @Alrighttt. The reverted code will be included in the next PR as it's already in a new feature branch. |
shamardy
approved these changes
Aug 30, 2024
shamardy
changed the title
mariocynicys
pushed a commit
that referenced
this pull request
Aug 30, 2024
This comit removes any sia lib related code from kdf and uses sia-rust repo as a dependency instead. `my_balance` is also implemented for siacoin in this commit.
mariocynicys
pushed a commit
that referenced
this pull request
Aug 30, 2024
This comit removes any sia lib related code from kdf and uses sia-rust repo as a dependency instead. `my_balance` is also implemented for siacoin in this commit.
mariocynicys
pushed a commit
that referenced
this pull request
Aug 30, 2024
This comit removes any sia lib related code from kdf and uses sia-rust repo as a dependency instead. `my_balance` is also implemented for siacoin in this commit.
dimxy
added a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
Sep 13, 2024
* dev: chore(RPCs): rename `get_peers_info` RPC to `get_directly_connected_peers` (KomodoPlatform#2195) chore(WASM-builds): remove `wasm-opt` overriding (KomodoPlatform#2200) fix(coins): add p2p feature to mm2_net dependency (KomodoPlatform#2210) chore(test): turn on debug assertion (KomodoPlatform#2204) feat(sia): extract sia lib to external repo (KomodoPlatform#2167) feat(eth-swap): eth tpu v2 methods, eth docker test enhancements (KomodoPlatform#2169) fix(cors): allow OPTIONS request to KDF server (KomodoPlatform#2191) docs(README): update commit badges to use dev branch (KomodoPlatform#2193) use default value for `komodo_proxy` (KomodoPlatform#2192) feat(cosmos): komodo-defi-proxy support (KomodoPlatform#2173)
dimxy
added a commit
that referenced
this pull request
Sep 13, 2024
* dev: chore(RPCs): rename `get_peers_info` RPC to `get_directly_connected_peers` (#2195) chore(WASM-builds): remove `wasm-opt` overriding (#2200) fix(coins): add p2p feature to mm2_net dependency (#2210) chore(test): turn on debug assertion (#2204) feat(sia): extract sia lib to external repo (#2167) feat(eth-swap): eth tpu v2 methods, eth docker test enhancements (#2169) fix(cors): allow OPTIONS request to KDF server (#2191) docs(README): update commit badges to use dev branch (#2193) use default value for `komodo_proxy` (#2192) feat(cosmos): komodo-defi-proxy support (#2173)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serde Changes
API Changes
fetch_and_parsefunction.api/addresses/:address/outputs/siacoinendpointRefactoring and Cleanup
There are many placeholders and TODOs still included in this pull request. Ready for review, but these sections of code are subject to change.
The next steps are to reorganize all the Sia code into a distinct "Sia Rust" crate. All DeFi framework logic will be separated.