Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set DataPlane's extensions through GatewayConfiguration #872

Closed
wants to merge 1 commit into from

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Nov 20, 2024

What this PR does / why we need it:

#453 missed configuring extensions for Gateway's DataPlane so this is adding the missing bit.

Which issue this PR fixes

Fixes #

Special notes for your reviewer:

This requires tests to be added.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@pmalek pmalek added this to the KGO v1.5.x milestone Nov 20, 2024
@pmalek pmalek self-assigned this Nov 20, 2024
@mlavacca
Copy link
Member

I have been exploring this issue when implementing #453, but it's not as straightforward as it might look. If we provision the DataPlane with Konnect configuration and a regular ControlPlane, we end up with KIC not being able to push configuration to the DataPlane (as it is not configured to accept the config from KIC), and it never gets ready. We likely need to improve the Controlplane as well to be able to receive KonnectExtension, to configure it to work in Konnect.

I've just created #874 to track this effort

@pmalek
Copy link
Member Author

pmalek commented Nov 21, 2024

I have been exploring this issue when implementing #453, but it's not as straightforward as it might look. If we provision the DataPlane with Konnect configuration and a regular ControlPlane, we end up with KIC not being able to push configuration to the DataPlane (as it is not configured to accept the config from KIC), and it never gets ready. We likely need to improve the Controlplane as well to be able to receive KonnectExtension, to configure it to work in Konnect.

I've just created #874 to track this effort

Ah indeed. I missed this because I only glanced at the fact that this field is not set for DataPlanes when deploying with Gateway.

I was also thinking about making ControlPlane able to get the Konnect extension. Thanks for creating the issue for this one 🙇

@pmalek pmalek closed this Nov 21, 2024
@pmalek pmalek deleted the gatewayconfiguration-extensions branch November 21, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants