Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: konnectExtension with bg enabled #910

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Dec 2, 2024

This commit fixes a bug related to KonnectExtensions for DataPlane configured with BlueGreen. In such configurations, the preview deployment was not customized with the Konnect-related field. Both the live and preview deployments are now properly customized with konnect fields.

What this PR does / why we need it:

Which issue this PR fixes

Fixes #909

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@mlavacca mlavacca requested a review from a team as a code owner December 2, 2024 15:18
@mlavacca mlavacca force-pushed the konnectextension-with-bg branch from 524a1c2 to df957c5 Compare December 2, 2024 15:27
This commit fixes a bug related to KonnectExtensions for DataPlane
configured with BlueGreen. In such configurations, the preview
deployment was not customized with the Konnect-related field.
Both the live and preview deployments are now properly customized with
konnect fields.

Signed-off-by: Mattia Lavacca <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
@mlavacca mlavacca force-pushed the konnectextension-with-bg branch from df957c5 to a0f753b Compare December 20, 2024 16:00
@mlavacca mlavacca enabled auto-merge (squash) December 20, 2024 16:00
@mlavacca mlavacca merged commit eaa360c into main Dec 20, 2024
21 checks passed
@mlavacca mlavacca deleted the konnectextension-with-bg branch December 20, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KonnectExtension is not used when creating BG preview Deployments
2 participants