feat: add metrics for konnect entity operations #953
+298
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
force-pushed
the
feat/metrics_konnect_entities
branch
from
635bb4f to
29675f9
Compare
pmalek
requested changes
Dec 24, 2024
randmonkey
force-pushed
the
feat/metrics_konnect_entities
branch
from
8a2bb2a to
4a476da
Compare
randmonkey
force-pushed
the
feat/metrics_konnect_entities
branch
from
4a476da to
6bf84c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add metrics for Konnect entity operations.
Which issue this PR fixes
Fixes #713
Special notes for your reviewer:
This is the first time to add custom metrics to the controller manager's metrics server so I used the same approach as KIC does.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes