Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): add ClearUnmatchingDeprecations function to align configs #473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nowNick
Copy link

@nowNick nowNick commented Oct 22, 2024

When a new plugin configuration is sent that contains information about some deprecated fields in order to produce correct diff we need to align the API response with given config.

KAG-5577

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.71%. Comparing base (82f0eb1) to head (a7dc20e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
+ Coverage   54.04%   54.71%   +0.66%     
==========================================
  Files          71       71              
  Lines        5599     5679      +80     
==========================================
+ Hits         3026     3107      +81     
+ Misses       1954     1953       -1     
  Partials      619      619              
Flag Coverage Δ
2.1 34.49% <100.00%> (+0.95%) ⬆️
2.2 44.99% <100.00%> (+0.80%) ⬆️
2.3 45.55% <100.00%> (+0.79%) ⬆️
2.4 45.62% <100.00%> (+0.79%) ⬆️
2.5 45.62% <100.00%> (+0.79%) ⬆️
2.6 45.62% <100.00%> (+0.79%) ⬆️
2.7 47.10% <100.00%> (+0.77%) ⬆️
2.8 47.10% <100.00%> (+0.77%) ⬆️
3.0 50.66% <100.00%> (+0.72%) ⬆️
3.1 51.99% <100.00%> (+0.70%) ⬆️
3.2 51.99% <100.00%> (+0.70%) ⬆️
3.3 51.99% <100.00%> (+0.70%) ⬆️
3.4 54.02% <100.00%> (+0.67%) ⬆️
3.5 52.17% <100.00%> (+0.70%) ⬆️
3.6 52.17% <100.00%> (+0.70%) ⬆️
community 41.20% <100.00%> (+0.85%) ⬆️
enterprise 53.30% <100.00%> (+0.68%) ⬆️
integration 54.71% <100.00%> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nowNick nowNick force-pushed the fix/clear-unmatching-deprecated-fields branch 2 times, most recently from f2e13bd to 6e4a200 Compare October 23, 2024 16:35
@Kong Kong deleted a comment from CLAassistant Oct 23, 2024
@nowNick nowNick force-pushed the fix/clear-unmatching-deprecated-fields branch 2 times, most recently from df36ae0 to a7dc20e Compare October 23, 2024 16:49
When a new plugin configuration is sent that contains information
about some deprecated fields in order to produce correct diff
we need to align the API response with given config.

KAG-5577
@nowNick nowNick marked this pull request as ready for review October 23, 2024 17:05
@nowNick nowNick requested review from a team as code owners October 23, 2024 17:05
@nowNick nowNick self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants