fix: login redirect was not handling hash #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mierenga
previously approved these changes
Sep 4, 2024
src/router/route-utils.ts
Outdated
Comment on lines
52
to
53
| const hash = `${redirectToPath.split('#')[1]}` | ||
| const redirectObject = { path: redirectToPath, hash: hash ? `#${hash}` : undefined } |
There was a problem hiding this comment.
nit: this could be optimized if done inside the if block
andrewwylde
force-pushed
the
fix/login-redirect-hash
branch
from
4e73eb9
to
14af741
Compare
Mierenga
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing a route to the
nextcallback with an object that looks like{path: string}, the hash is not included. When the hash is included in the redirect, then, it would continually compare the path to the redirectPath, and they would not match (one would be missing the hash). Therefore it would cause an infinite redirect loop causing a crash/OOM.By checking for a hash and passing it along to the
nextcallback, it allows correct comparison, and redirects properly.