Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add version information to CRDs #203

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Dec 23, 2024

What this PR does / why we need it:

This PR adds version information to generated CRDs via the kubernetes-configuration.konghq.com/version annotation.

This annotation is created with the generate.crds makefile target and the value of that annotation is taken from the VERSION file.

Additionally to automate the release process, each time a commit with VERSION file change is merged, a release is triggered.

The VERSION file contains 2 lines:

  • The first line is the version number (e.g. 1.0.0).
  • The second line indicates if the version should be marked as latest or not
    (e.g. latest for latest, anything else is not marked as latest).

Which issue this PR fixes

Fixes #

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@pmalek pmalek added the area/ci label Dec 23, 2024
@pmalek pmalek self-assigned this Dec 23, 2024
@pmalek pmalek force-pushed the add-version-to-crds branch 3 times, most recently from 3aeb291 to 0e9b25f Compare December 23, 2024 16:10
@pmalek pmalek marked this pull request as ready for review December 23, 2024 16:14
@pmalek pmalek requested a review from a team as a code owner December 23, 2024 16:14
@pmalek pmalek force-pushed the add-version-to-crds branch from 0e9b25f to dcab328 Compare December 23, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant