-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crd): add CredentialBasicAuth #83
Conversation
be3e20e
to
a847515
Compare
a847515
to
090267a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So a CredentialBasicAuth
represents a relationship that a KongConsumer
referencing a Secret
as a basic auth credential attached to the consumer?
Yes, that's the idea. If more Consumers use the same credential (not sure how realistic use case this is) this will create multiple credential objects for each usage. |
Blocked for now before we get consensus on how this should look like: https://kongstrong.slack.com/archives/C079GK3KB9R/p1726735862213059 |
0bf6bf1
to
27d7191
Compare
27d7191
to
b643aa6
Compare
Unblocked. This for now will contain only the consumer ref and verbatim credential field. This will replace the "old" way of binding consumers to credentials ( In the future we'll be able to provide support for "old" way of binding - using the |
4c997dc
to
905bb57
Compare
One afterthought I just had: shouldn't we name the CRD |
I was thinking about this one and went with no prefix. If you feel that would make it more consistent (which in hindsight seems like it would) I can make the change 👍 |
Yeah, I think we should keep it consistent. 👍 |
What this PR does / why we need it:
This PR adds
CredentialBasicAuth
CRD which will be used by KGO.Resources of this type will be created when
KongConsumer
will use aSecret
as credential. This will result inCredentialBasicAuth
being created, constituting a 1:1 mapping with a credential resource in Konnect.Which issue this PR fixes
Related to Kong/gateway-operator#617
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect significant changes