chore(ci): don't fix linting issues in CI (#5314)

Kong · Dec 8, 2023 · 1059a0a · 1059a0a
1 parent cb1caa4
commit 1059a0a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.github/workflows/_linters.yaml b/.github/workflows/_linters.yaml
@@ -18,6 +18,9 @@ jobs:
           go-version-file: third_party/go.mod
 
       - name: Run lint
+        env:
+          # Our .golangci.yaml has fix: true, but we don't want that in CI therefore the below override.
+          GOLANGCI_LINT_FLAGS: "--fix=false"
         run: make lint
 
       - name: Verify manifest consistency

diff --git a/Makefile b/Makefile
@@ -161,7 +161,7 @@ lint: verify.tidy golangci-lint staticcheck looppointer
 
 .PHONY: golangci-lint
 golangci-lint: golangci-lint.download
-	$(GOLANGCI_LINT) run --verbose --config $(PROJECT_DIR)/.golangci.yaml
+	$(GOLANGCI_LINT) run --verbose --config $(PROJECT_DIR)/.golangci.yaml $(GOLANGCI_LINT_FLAGS)
 
 .PHONY: staticcheck
 staticcheck: staticcheck.download