-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9주차 미션 / 서버 2조 강상민 #7
Open
isoo127
wants to merge
3
commits into
Konkuk-KUIT:master
Choose a base branch
from
isoo127-Archive:isoo127
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
35 changes: 30 additions & 5 deletions
35
src/main/java/kuit3/backend/common/argument_resolver/JwtAuthHandlerArgumentResolver.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,55 @@ | ||
package kuit3.backend.common.argument_resolver; | ||
|
||
import jakarta.servlet.http.HttpServletRequest; | ||
import kuit3.backend.common.exception.jwt.unauthorized.JwtInvalidTokenException; | ||
import kuit3.backend.jwt.JwtProvider; | ||
import kuit3.backend.service.AuthService; | ||
import lombok.NonNull; | ||
import lombok.RequiredArgsConstructor; | ||
import lombok.extern.slf4j.Slf4j; | ||
import org.springframework.core.MethodParameter; | ||
import org.springframework.http.HttpHeaders; | ||
import org.springframework.security.access.prepost.PreAuthorize; | ||
import org.springframework.stereotype.Component; | ||
import org.springframework.web.bind.support.WebDataBinderFactory; | ||
import org.springframework.web.context.request.NativeWebRequest; | ||
import org.springframework.web.method.support.HandlerMethodArgumentResolver; | ||
import org.springframework.web.method.support.ModelAndViewContainer; | ||
|
||
import static kuit3.backend.common.response.status.BaseExceptionResponseStatus.INVALID_TOKEN; | ||
|
||
@Slf4j | ||
@Component | ||
@RequiredArgsConstructor | ||
public class JwtAuthHandlerArgumentResolver implements HandlerMethodArgumentResolver { | ||
|
||
private final JwtProvider jwtProvider; | ||
private final AuthService authService; | ||
|
||
@Override | ||
public boolean supportsParameter(MethodParameter parameter) { | ||
log.info(parameter.getParameterName() + parameter.getParameterType()); | ||
boolean hasAnnotation = parameter.hasParameterAnnotation(PreAuthorize.class); | ||
boolean hasType = long.class.isAssignableFrom(parameter.getParameterType()); | ||
boolean hasType = Long.class.isAssignableFrom(parameter.getParameterType()); | ||
log.info("hasAnnotation={}, hasType={}, hasAnnotation && hasType={}", hasAnnotation, hasType, hasAnnotation&&hasType); | ||
return hasAnnotation && hasType; | ||
return true; | ||
} | ||
|
||
@Override | ||
public Object resolveArgument(MethodParameter parameter, ModelAndViewContainer mavContainer, NativeWebRequest webRequest, WebDataBinderFactory binderFactory) throws Exception { | ||
public Object resolveArgument(@NonNull MethodParameter parameter, ModelAndViewContainer mavContainer, NativeWebRequest webRequest, WebDataBinderFactory binderFactory) { | ||
HttpServletRequest request = (HttpServletRequest) webRequest.getNativeRequest(); | ||
log.info("userId={}", request.getAttribute("userId")); | ||
return request.getAttribute("userId"); | ||
String accessToken = (String)request.getAttribute("jwtToken"); | ||
|
||
String email = jwtProvider.getPrincipal(accessToken); | ||
validatePayload(email); | ||
|
||
return authService.getUserIdByEmail(email); | ||
} | ||
|
||
private void validatePayload(String email) { | ||
if (email == null) { | ||
throw new JwtInvalidTokenException(INVALID_TOKEN); | ||
} | ||
} | ||
|
||
} |
30 changes: 0 additions & 30 deletions
30
src/main/java/kuit3/backend/common/argument_resolver/JwtUserHandlerArgumentResolver.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 0 additions & 70 deletions
70
src/main/java/kuit3/backend/common/interceptor/JwtUserInterceptor.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
src/main/java/kuit3/backend/dto/restaurant/GetRestaurantResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
package kuit3.backend.dto.restaurant; | ||
|
||
import lombok.AllArgsConstructor; | ||
import lombok.Getter; | ||
import lombok.NoArgsConstructor; | ||
import lombok.Setter; | ||
|
||
@Getter | ||
@Setter | ||
@NoArgsConstructor | ||
@AllArgsConstructor | ||
public class GetRestaurantResponse { | ||
|
||
private Long id; | ||
private String name; | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolver에서 현재 hasAnnotation으로 해당 어노테이션인지를 확인을 합니다. 하지만 현재 import 해오는 클래스를 보면 저희가 만든 어노테이션이 아닌 spring security에서 제공하는 어노테이션을 가져와서 사용하고 있습니다. 아마 두 개의 어노테이션이 다르기에 false가 나오는 문제가 발생하는 것으로 보입니다.