Skip to content

Commit

Permalink
Specify slf4j-api instead of slf4j-simple. (#934)
Browse files Browse the repository at this point in the history
When used as a library in other components slf4j-api should be used,
 allowing the component to select the logging backend themselves
 (for example logback).
  • Loading branch information
erikogenvik authored Nov 6, 2024
1 parent 65ce2ea commit 3c153fe
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dataframe-jdbc/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ dependencies {
testImplementation(libs.h2db)
testImplementation(libs.mssql)
testImplementation(libs.junit)
testImplementation(libs.sl4j)
testImplementation(libs.sl4jsimple)
testImplementation(libs.jts)
testImplementation(libs.kotestAssertions) {
exclude("org.jetbrains.kotlin", "kotlin-stdlib-jdk8")
Expand Down
3 changes: 2 additions & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ kotlinpoet = { group = "com.squareup", name = "kotlinpoet", version.ref = "kotli
swagger = { group = "io.swagger.parser.v3", name = "swagger-parser", version.ref = "openapi" }

kotlinLogging = { group = "io.github.oshai", name = "kotlin-logging", version.ref = "kotlinLogging" }
sl4j = { group = "org.slf4j", name = "slf4j-simple", version.ref = "sl4j" }
sl4j = { group = "org.slf4j", name = "slf4j-api", version.ref = "sl4j" }
sl4jsimple = { group = "org.slf4j", name = "slf4j-simple", version.ref = "sl4j" }
android-gradle-api = { group = "com.android.tools.build", name = "gradle-api", version.ref = "android-gradle-api" }
android-gradle = { group = "com.android.tools.build", name = "gradle", version.ref = "android-gradle-api" }
kotlin-gradle-plugin = { group = "org.jetbrains.kotlin", name = "kotlin-gradle-plugin" }
Expand Down

0 comments on commit 3c153fe

Please sign in to comment.