Skip to content

Commit

Permalink
Merge branch '6.2' into 6.3
Browse files Browse the repository at this point in the history
* 6.2:
  [AllBundles] Fix codestyle issues
  • Loading branch information
acrobat committed Dec 20, 2023
2 parents a90f2ae + 91e23fe commit 2478031
Show file tree
Hide file tree
Showing 21 changed files with 34 additions and 108 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,6 @@ public function onKernelRequest(RequestEvent $event)
}
}

/**
* @param TokenInterface $token
*/
private function isAdminToken($providerKey, TokenInterface $token = null): bool
{
if (null === $token) {
Expand Down
2 changes: 0 additions & 2 deletions src/Kunstmaan/AdminBundle/Helper/Menu/MenuBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,6 @@ public function getTopChildren()
/**
* Get immediate children of the specified menu item
*
* @param MenuItem $parent
*
* @return MenuItem[]
*/
public function getChildren(MenuItem $parent = null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ class CookieAdminListConfigurator extends AbstractDoctrineORMAdminListConfigurat
*/
private $domainConfiguration;

/**
* @param EntityManager $em The entity manager
* @param AclHelper $aclHelper The acl helper
* @param DomainConfigurationInterface $domainConfiguration
*/
public function __construct(EntityManager $em, AclHelper $aclHelper = null, DomainConfigurationInterface $domainConfiguration = null)
{
parent::__construct($em, $aclHelper);
Expand Down
14 changes: 0 additions & 14 deletions src/Kunstmaan/CookieBundle/Entity/Cookie.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ class Cookie extends AbstractEntity
private $domain;

/**
* Set name
*
* @param string $name
*
* @return Cookie
Expand All @@ -70,8 +68,6 @@ public function setName($name)
}

/**
* Get name
*
* @return string
*/
public function getName()
Expand All @@ -80,8 +76,6 @@ public function getName()
}

/**
* Set description
*
* @param string $description
*
* @return Cookie
Expand All @@ -94,8 +88,6 @@ public function setDescription($description)
}

/**
* Get description
*
* @return string
*/
public function getDescription()
Expand All @@ -104,10 +96,6 @@ public function getDescription()
}

/**
* Set type
*
* @param CookieType $type
*
* @return Cookie
*/
public function setType(CookieType $type = null)
Expand All @@ -118,8 +106,6 @@ public function setType(CookieType $type = null)
}

/**
* Get type
*
* @return CookieType
*/
public function getType()
Expand Down
7 changes: 3 additions & 4 deletions src/Kunstmaan/CookieBundle/Helper/Menu/CookieMenuAdaptor.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,9 @@ public function adaptChildren(MenuBuilder $menu, array &$children, MenuItem $par
}

/**
* @param Request $request
* @param string $route
* @param string $uniqueId
* @param string $label
* @param string $route
* @param string $uniqueId
* @param string $label
*/
private function addMenuItem(MenuBuilder $menu, array &$children, MenuItem $parent, Request $request = null, $route, $uniqueId, $label)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Kunstmaan/MediaBundle/Controller/ChooserController.php
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public function chooserShowFolderAction(Request $request, $folderId): Response
];

$forms = [];
foreach ($this->mediaManager->getFolderAddActions() as $addAction) {
foreach ($this->mediaManager->getFolderAddActions() as $addAction) {
$forms[$addAction['type']] = $this->createTypeFormView($this->mediaManager, $addAction['type']);
}

Expand Down
24 changes: 1 addition & 23 deletions src/Kunstmaan/MediaBundle/Entity/Folder.php
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,6 @@ public function setRel($rel)
}

/**
* Get createdAd
*
* @return \DateTime
*/
public function getCreatedAt()
Expand All @@ -234,8 +232,6 @@ public function getCreatedAt()
}

/**
* Set createdAd
*
* @param \DateTime $createdAt
*
* @return Folder
Expand All @@ -248,8 +244,6 @@ public function setCreatedAt($createdAt)
}

/**
* Get updatedAt
*
* @return \DateTime
*/
public function getUpdatedAt()
Expand All @@ -258,8 +252,6 @@ public function getUpdatedAt()
}

/**
* Set updatedAt
*
* @param \DateTime $updatedAt
*
* @return Folder
Expand All @@ -272,7 +264,7 @@ public function setUpdatedAt($updatedAt)
}

/**
* @return Folder[]:
* @return Folder[]
*/
public function getParents()
{
Expand All @@ -287,8 +279,6 @@ public function getParents()
}

/**
* Get parent
*
* @return Folder
*/
public function getParent()
Expand All @@ -297,10 +287,6 @@ public function getParent()
}

/**
* Set parent
*
* @param Folder $parent
*
* @return Folder
*/
public function setParent(Folder $parent = null)
Expand All @@ -311,8 +297,6 @@ public function setParent(Folder $parent = null)
}

/**
* Add a child
*
* @return Folder
*/
public function addChild(Folder $child)
Expand All @@ -324,8 +308,6 @@ public function addChild(Folder $child)
}

/**
* Add file
*
* @return Folder
*/
public function addMedia(Media $media)
Expand All @@ -336,8 +318,6 @@ public function addMedia(Media $media)
}

/**
* Get media
*
* @param bool $includeDeleted
*
* @return ArrayCollection
Expand Down Expand Up @@ -376,8 +356,6 @@ public function hasActive($id)
}

/**
* Get child folders
*
* @param bool $includeDeleted
*
* @return ArrayCollection
Expand Down
2 changes: 0 additions & 2 deletions src/Kunstmaan/NodeBundle/Entity/NodeVersionLock.php
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,6 @@ public function getOwner()
/**
* Set nodeTranslation
*
* @param \Kunstmaan\NodeBundle\Entity\NodeTranslation $nodeTranslation
*
* @return NodeVersionLock
*/
public function setNodeTranslation(NodeTranslation $nodeTranslation = null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public function __construct(
*
* @param BaseUser|null $user
*
* @throws AccessDeniedException
* @throws AccessDeniedException
*/
public function publish(NodeTranslation $nodeTranslation, $user = null)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ public function isNodeVersionLocked(BaseUser $user, NodeTranslation $nodeTransla
}

/**
* @param BaseUser $userToExclude
* @param bool $isPublicNodeVersion
* @param bool $isPublicNodeVersion
*
* @return array
*/
Expand Down Expand Up @@ -107,8 +106,7 @@ protected function createNodeVersionLock(BaseUser $user, NodeTranslation $nodeTr
/**
* When editing a node, check if there is a lock for this node translation.
*
* @param bool $isPublicVersion
* @param BaseUser $userToExclude
* @param bool $isPublicVersion
*
* @return NodeVersionLock[]
*/
Expand Down
3 changes: 1 addition & 2 deletions src/Kunstmaan/NodeBundle/Helper/NodeHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,7 @@ public function prepareNodeVersion(NodeVersion $nodeVersion, NodeTranslation $no
}

/**
* @param bool $isStructureNode
* @param TabPane $tabPane
* @param bool $isStructureNode
*
* @return NodeTranslation
*/
Expand Down
3 changes: 0 additions & 3 deletions src/Kunstmaan/NodeBundle/Helper/NodeMenu.php
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,6 @@ public function setLocale($locale)
$this->locale = $locale;
}

/**
* @param Node $currentNode
*/
public function setCurrentNode(Node $currentNode = null)
{
$this->currentNode = $currentNode;
Expand Down
2 changes: 0 additions & 2 deletions src/Kunstmaan/NodeBundle/Repository/NodeRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,6 @@ public function getAllMenuNodes(
/**
* Get all parents of a given node. We can go multiple levels up.
*
* @param Node $node
* @param string $lang
*
* @return Node[]
Expand Down Expand Up @@ -386,7 +385,6 @@ public function getAllParents(Node $node = null, $lang = null)
/**
* Get the root node of a given node.
*
* @param Node $node
* @param string $lang
*
* @return Node
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,8 @@ public function getNodeTranslationByNodeId(int $nodeId, string $lang)
/**
* Get max children weight
*
* @param Node $parentNode
* @param string $lang (optional) Only return max weight for the
* given language
* @param string $lang (optional) Only return max weight for the
* given language
*
* @return int
*/
Expand All @@ -64,9 +63,8 @@ public function getMaxChildrenWeight(Node $parentNode = null, $lang = null)
/**
* Get min children weight
*
* @param Node $parentNode
* @param string $lang (optional) Only return min weight for the
* given language
* @param string $lang (optional) Only return min weight for the
* given language
*
* @return int
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@ class NodeVersionLockRepository extends \Doctrine\ORM\EntityRepository
/**
* Check if there is a nodetranslation lock that's not passed the 30 minute threshold.
*
* @param bool $isPublicVersion
* @param int $threshold
* @param BaseUser $userToExclude
* @param bool $isPublicVersion
* @param int $threshold
*
* @return NodeVersionLock[]
*/
Expand Down
1 change: 0 additions & 1 deletion src/Kunstmaan/NodeBundle/Twig/NodeTwigExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ public function getUrlByInternalName($internalName, $locale, $parameters = [], $

/**
* @param string $locale
* @param Node $node
* @param bool $includeHiddenFromNav
*
* @return NodeMenu
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,6 @@ public function getSlice($offset, $length)
}

/**
* @param ResultSet $result
*
* @return array|ResultSet
*/
protected function processResponse(ResultSet $result = null)
Expand Down
Loading

0 comments on commit 2478031

Please sign in to comment.