Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] restyle navigation #2774

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[WIP] restyle navigation #2774

wants to merge 10 commits into from

Conversation

FVKVN
Copy link
Contributor

@FVKVN FVKVN commented Oct 1, 2020

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

ProfessorKuma
ProfessorKuma suggested changes Oct 1, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • This PR seems to need a milestone of a minor release.

@ProfessorKuma ProfessorKuma added this to the 5.7.0 milestone Oct 1, 2020
ProfessorKuma
ProfessorKuma approved these changes Oct 1, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat modified the milestones: 5.7.0, Unknown (WIP) Oct 7, 2020
ProfessorKuma
ProfessorKuma suggested changes Oct 20, 2020
View reviewed changes
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • This PR seems to need a milestone of a minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorKuma ProfessorKuma ProfessorKuma requested changes

Assignees
No one assigned
Labels
Type: Feature
Projects
None yet
Milestone
Unknown (WIP)
Development

Successfully merging this pull request may close these issues.
3 participants
@FVKVN @ProfessorKuma @acrobat