Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][AdminBundle] Migrate CKEditor4 to CKEditor5 #2820

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dbeerten
Copy link
Contributor

@dbeerten dbeerten commented Nov 5, 2020

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Fixed tickets #2135

TODO:

  • Allow custom config (or extended config) on project level
    Don't know if this is possible since you can't/shouldn't load different builds on the same page.
    https://ckeditor.com/docs/ckeditor5/latest/builds/guides/integration/advanced-setup.html#scenario-3-using-two-different-editors
    You can change the toolbar property for different instances, but you can't add plugins to an existing build.
  • Update cookbook doc for defining custom ckeditor configuration
  • Remove CKEditor4 code, ckEditorConfigs & code examples
  • Internal links: Browser? (custom plugin, not default in CKEditor5)
  • Reduce toolbar to essentials: no tables, no images, no headings
  • Word count / Max length?
  • Language UI / Content

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • It seems that you should have submitted to the next major branch.
  • This PR seems to need a milestone of a major release.

@ProfessorKuma ProfessorKuma added this to the 6.0.0 milestone Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants