Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DashboardBundle] Fix controller route attribute resolver in DashboardWidget #3325

Merged
merged 1 commit into from
Dec 21, 2023
Merged

[DashboardBundle] Fix controller route attribute resolver in DashboardWidget #3325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/Kunstmaan/DashboardBundle/Widget/DashboardWidget.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ public function resolvedController()
{
$annotationReader = new AnnotationReader();
$reflectionMethod = new \ReflectionMethod($this->controller, 'widgetAction');

// NEXT_MAJOR Remove annotation support
$methodAnnotations = $annotationReader->getMethodAnnotations($reflectionMethod);
foreach ($methodAnnotations as $annotation) {
if ($annotation instanceof Route) {
Expand All @@ -39,6 +41,16 @@ public function resolvedController()
}
}

throw new \Exception('There is no route annotation');
$methodRouteAttributes = $reflectionMethod->getAttributes(Route::class, \ReflectionAttribute::IS_INSTANCEOF);
if ($methodRouteAttributes === []) {
throw new \Exception('There is no route annotation or attribute');
}

$attributeInstance = $methodRouteAttributes[0]->newInstance();
if (null === $attributeInstance->getName()) {
throw new \Exception('The name is not configured in the attribute');
}

return $attributeInstance->getName();
}
}