Add support for confirm password fields #1363
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for confirm password fields in sign-up pages.
Current behavior
The current behavior when using a sign up page will fill the username and password, but not any confirm password fields. This is annoying because it forces the user to re-open keepassdx to copy the autogenerated password, and paste it in the form.
New behavior
The new behavior attempts to detect confirm password fields by checking for additional password fields past the first one. This cuts out the step of re-opening keepassdx and copying the password.
Testing
I tested this on my own website and the google.com account creation page.
I was not able to find any native apps on my phone that had a confirm password field.