-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to v1.2 #1197
Bump to v1.2 #1197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me -- it's hard to really comment. I was wondering though, in the example config/joboptions, are you mostly using parameter settings that are already the default? If you want to make it a great example, indicating only those settings you'd typically want to play with or change would make it more useful to the beginner. Also, I have no idea if this is the case, but if there are typical sets of parameter changes that would go together, they could be bundled up in a predefined function (like the different simulation types are, for example) to minimize the risk that a user picks bad parameter combinations.
@bryngemark |
@pbutti Can you post a config (or configs if you did multiple steps) you used to run the tracking? I tried the following and got an error about using a pre-existing product. These errors usually crop up from running processors in the wrong order (or omitting ones that are necessary). ProcessCommands
Error
sim.pyThis is just a copy of from LDMX.Framework import ldmxcfg
# create my process object
p = ldmxcfg.Process( "test" )
# how many events to process?
import sys
p.maxEvents = 10
if len(sys.argv) > 1 :
p.maxEvents = int(sys.argv[1])
# we want to see every event
p.logFrequency = 1
p.termLogLevel = 0
# Set a run number
p.run = 9001
# we also only have an output file
p.outputFiles = [ "justSim_" + str(p.maxEvents) + "_events.root" ]
from LDMX.SimCore import simulator as sim
import LDMX.Ecal.EcalGeometry
import LDMX.Hcal.HcalGeometry
mySim = sim.simulator( "mySim" )
mySim.setDetector( 'ldmx-det-v14' , True )
# Get a pre-written generator
from LDMX.SimCore import generators as gen
mySim.generators.append( gen.single_4gev_e_upstream_tagger() )
# add your configured simulation to the sequence
mySim.description = 'Basic test Simulation'
p.sequence.append( mySim ) trk.pyimport argparse
from pathlib import Path
parser = argparse.ArgumentParser()
parser.add_argument('sim_file', type=Path)
args = parser.parse_args()
from LDMX.Framework import ldmxcfg
from LDMX.Tracking import examples
p = examples.single_e_track_recon_10um()
from LDMX.Tracking import geo
p.inputFiles = [ str(args.sim_file) ]
p.outputFiles = [ args.sim_file.stem + '_tracked.root' ] |
It looks like the But it only takes either the RecoilSimHits or the TaggerSimHits as input? We might need to update Tracking and make a new release of it before it can be merged. |
The The truth seeder runs only once. The hit inputs have been superseded by the usage of scoring plane information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alrightie, after conferring with @pbutti , I made some usability patches and then bumped the version patch number. Now I am happy with merging this in and start the work of integrating it into the CI.
I am updating ldmx-sw, here are the details.
Bump tracking to stable release v1.2
Check List
I successfully compiled ldmx-sw with my developments
I ran my developments and the following shows that they are successful.
< put plots or some other proof that your developments work >