Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 8gev detector name in GDML #1358

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Fix 8gev detector name in GDML #1358

merged 1 commit into from
Jun 3, 2024

Conversation

tvami
Copy link
Member

@tvami tvami commented May 31, 2024

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Resolves #1323

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

When running the tests, this should have no visible effect at all

@tvami
Copy link
Member Author

tvami commented Jun 1, 2024

Log failure is according to expectation:

<  [ Process ] 1 : RunHeader { run: 1, numTries: 76625, detectorName: ldmx-det-v14, description: One e- fired far upstream with Dark Brem turned on and biased up in target
  ---
>  [ Process ] 1 : RunHeader { run: 1, numTries: 76625, detectorName: ldmx-det-v14-8gev, description: One e- fired far upstream with Dark Brem turned on and biased up in target

@tvami tvami merged commit 7c16cf4 into trunk Jun 3, 2024
5 of 7 checks passed
@tvami tvami deleted the iss1323-fix8gev-gdml branch June 3, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix detector name in ldmx-det-v14-8gev GMDL
3 participants