Clang format ldmx-sw

[tvami]

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This resolves #1294

Check List

• I successfully compiled ldmx-sw with my developments
• I ran my developments and the following shows that they are successful.

Running

git ls-tree -r HEAD --name-only | egrep '(\.h|\.cxx)$' > format.list
clang-format --style=Google -Werror --dry-run $(cat format.list)

returns nothing now!
There is absolutely nothing expected to change, this is a cosmetics only PR.

After this is merged, we should change the CI to make the clang format checks automatically.

[tomeichlersmith]

I'm thinking we could introduce the clang-format testing in this PR as well and I don't think it would be too hard given we've done it for other submodules in the past.

• Copy .clang-format from Framework/.clang-format (it's just saying using the Google style right now, but having a file will make it easier in the future to define ldmx-sw wide format definitions)
• Copy over action from Framework or SimCore (under .github/workflows/format-check.yml in either of those directories). To avoid submodules, probably would want to update the script that either of those runs .github/format. I'd be happy with either writing the few lines of code into the action yaml or putting a format script into our scripts/ directory which we can call from CI.
• Remove the formatting infra from Framework/SimCore. git rm -r Framework/.clang-format Framework/.github SimCore/.clang-format SimCore/.github (just cleaning up)

[tvami]

I'd be happy with either writing the few lines of code into the action yaml

I'm not sure how to skip the submodules. For now I did the rest in 7c988da

[tvami]

oh I think it works out of the box: https://github.com/LDMX-Software/ldmx-sw/actions/runs/9421674449/job/25956257560

[tomeichlersmith]

For skipping submodules, it would mainly entail changing the find ... command to the git ls-tree ... command to avoid files in another repo. It looks like the files in the other repos either follow the Google style as well or have a different extension so we don't check them.

ldmx-sw/.github/format-check

Line 23 in 7c988da

find . -type f \( -name '*.h' -o -name '*.cxx' \) > ${TMPDIR:-/tmp}/files-to-format.list

That is what I meant, but luckily there is another way! Just have the action not even clone the submodules :) then we are all good.

ldmx-sw/.github/workflows/format-check.yml

Line 12 in 7c988da

- uses: actions/checkout@v3

[tvami]

Just have the action not even clone the submodules :)

ahh that's why it worked, because I didnt have the recursive option setup. Gotcha!