-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang format ldmx-sw #1362
Clang format ldmx-sw #1362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking we could introduce the clang-format testing in this PR as well and I don't think it would be too hard given we've done it for other submodules in the past.
- Copy
.clang-format
fromFramework/.clang-format
(it's just saying using the Google style right now, but having a file will make it easier in the future to define ldmx-sw wide format definitions) - Copy over action from Framework or SimCore (under
.github/workflows/format-check.yml
in either of those directories). To avoid submodules, probably would want to update the script that either of those runs.github/format
. I'd be happy with either writing the few lines of code into the action yaml or putting aformat
script into ourscripts/
directory which we can call from CI. - Remove the formatting infra from Framework/SimCore.
git rm -r Framework/.clang-format Framework/.github SimCore/.clang-format SimCore/.github
(just cleaning up)
I'm not sure how to skip the submodules. For now I did the rest in 7c988da |
oh I think it works out of the box: https://github.com/LDMX-Software/ldmx-sw/actions/runs/9421674449/job/25956257560 |
For skipping submodules, it would mainly entail changing the Line 23 in 7c988da
That is what I meant, but luckily there is another way! Just have the action not even clone the submodules :) then we are all good.
|
ahh that's why it worked, because I didnt have the |
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
This resolves #1294
Check List
Running
returns nothing now!
There is absolutely nothing expected to change, this is a cosmetics only PR.
After this is merged, we should change the CI to make the clang format checks automatically.