feat(bindings): add high throughput fifo properties #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to line up with the spec proposal. |
VisualBean
reviewed
Oct 30, 2023
|
I am ready to move this forward - once the spec change is in. |
|
@VisualBean asyncapi/bindings#216 has been approved and merged. Could we get this merged in please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This PR adds the missing properties required to enable high throughput on a FIFO queue. The two properties are deduplicationScope and fifoThroughputLimit. As outlined in the AWS documentation - https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/high-throughput-fifo.html#enable-high-throughput-fifo.
I have raised a PR on the AsyncAPI binding repo which has been approved and is awaiting merge - asyncapi/bindings#216.
Changelog
deduplicationScopeFIFO queue binding property to both channel and operation binding.fifoThroughputLimitFIFO queue binding property to both channel and operation binding.