Correctly handle include includes #88
Open
+166
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used by pylems
- if `include_includes` is set, we replace the `Include` statements with their contents - if not, the `Include` statements are kept as part of the model and when the model is exported, they're also exported. Fixes #86
|
the main change is in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If include_include is True:
Includeline are replaced with the contents of the fileIncludestatement is retained.We also add tests to check these two scenarios.
Note that when the
Includeline has been replaced by the file contents, we do not keep the name of the file around. So, we cannot then export a version of the model where theIncludelines are present again instead of the file contents. It may be possible to modify the code to allow that by adding arguments to theexport_to_domandexport_to_filefunctions, but we do not currently do this.