fix: Borders on invisible border window and monocle mode fixes #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [net2](https://github.com/deprecrated/net2-rs) from 0.2.38 to 0.2.39. - [Commits](deprecrated/net2-rs@0.2.38...0.2.39) --- updated-dependencies: - dependency-name: net2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.164 to 1.0.165. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.164...v1.0.165) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [quote](https://github.com/dtolnay/quote) from 1.0.28 to 1.0.29. - [Release notes](https://github.com/dtolnay/quote/releases) - [Commits](dtolnay/quote@1.0.28...1.0.29) --- updated-dependencies: - dependency-name: quote dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
This commit applies a technique shared by Lars from GlazeWM and first noticed by J.SH on Discord to add the SWP_NOSENDCHANGING flag when positioning windows to overcome any hard-coded minimum width restrictions an application might have.
Bumps [clap](https://github.com/clap-rs/clap) from 4.3.8 to 4.3.11. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@v4.3.8...v4.3.11) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [serde_yaml](https://github.com/dtolnay/serde-yaml) from 0.9.21 to 0.9.22. - [Release notes](https://github.com/dtolnay/serde-yaml/releases) - [Commits](dtolnay/serde-yaml@0.9.21...0.9.22) --- updated-dependencies: - dependency-name: serde_yaml dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [sysinfo](https://github.com/GuillaumeGomez/sysinfo) from 0.29.2 to 0.29.4. - [Changelog](https://github.com/GuillaumeGomez/sysinfo/blob/master/CHANGELOG.md) - [Commits](https://github.com/GuillaumeGomez/sysinfo/commits) --- updated-dependencies: - dependency-name: sysinfo dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
mjblacker
changed the title
LGUG2Z
reviewed
Jul 13, 2023
| @@ -108,25 +108,23 @@ impl Border { | |||
| Self::create("komorebi-border-window")?; | |||
| } | |||
|
|
|||
| let mut should_expand_border = false; | |||
| let mut should_contract_border = true; | |||
There was a problem hiding this comment.
Can you include some photographs and videos of the before and after of this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for borders on invisible border windows leaving a gap (contract borders into the window to match the visible area), may only show issue when using thinner than default border width.
Fix for monocle mode border not showing when switching to second workspace as single window (no containers in workspace).
Fix for monocle window not selectable when focusing in direction across multiple screens, would previously show "no container" message as it was only looking in the focused workspace containers ring.