Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests/warnings when SOS is not online #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdwdirect
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   75.22%   75.22%           
=======================================
  Files         108      108           
  Lines        7658     7658           
=======================================
  Hits         5761     5761           
  Misses       1897     1897

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a7559...9176884. Read the comment docs.

@daboehme
Copy link
Member

We'll have to adapt the SOS service to the new Channel interface before this can be merged. Shouldn't be anything major, mostly the callback dispatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants