Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced MSR Coverage for Intel CPU Models via New Allowlists #141

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

infamicstudios
Copy link
Contributor

New Allowlists Introduced for Intel CPU Families/Models:

06_2A, 06_2D, 06_3A, 06_3C, 06_3D, 06_3E, 06_3F, 06_45, 06_46, 06_47, 06_4E, 06_4F, 06_55, 06_56, 06_5E, 06_66, 06_6A, 06_6C, 06_7D, 06_7E, 06_8C, 06_8D, 06_8E, 06_8F, 06_97, 06_9A, 06_9E, 06_A5, 06_A6, 06_BF

Full Coverage:

These allowlists encompass all the applicable MSRs for the mentioned CPU models as detailed in the Intel 64 and IA-32 Architectures Software Development Manual (Volume 4, 335592-079US, March 2023).

Objective:

Facilitate the creation and customization of allowlists through expanded templates, ensuring comprehensive coverage and enhanced safety.

Core Functionality:

Unchanged.

Duncan added 2 commits August 16, 2023 15:14
…added additional allowlists to extend support to more processor families
Copy link
Collaborator

@rountree rountree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please. This went through far more iterations than I had intended, but we've ended up with something that's far more useful than what we've had before.

To give a concrete example of just how useful this is: I wanted to be able to monitor temperature and knew there was an MSR for it, so I cracked open volume 3B and started grepping. I found MSR_THERM_STATUS. Does it exist on this MSR? If so, is it core or package scope?

Opening up the new allowlist confirmed its existence as well as giving me the MSR address and table. That allowed me to track down the core/package info more or less immediately. As an added bonus, I saw the IA32_PACKAGE_THERM_STATUS MSR in the allowlist, which I wouldn't have noticed otherwise.

This PR is a terrific improvement to our workflow. I'll be using this branch until it goes into mainline.

@slabasan slabasan merged commit eff7751 into LLNL:main Sep 6, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants