Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes several missing-prototype warnings. #165

Merged
merged 9 commits into from
Sep 23, 2024

Conversation

rountree
Copy link
Collaborator

@rountree rountree commented Aug 4, 2024

Compiling under Linux 6.9.9 and gcc 10.3.1.

Fixes #164

Compiling under Linux 6.9.9 and gcc 10.3.1.
@rountree rountree requested a review from slabasan as a code owner August 4, 2024 05:49
@slabasan slabasan added this to the v1.8.0 milestone Sep 13, 2024
msr-smp.c Outdated Show resolved Hide resolved
msr-smp.h Outdated Show resolved Hide resolved
msr_allowlist.c Outdated Show resolved Hide resolved
msr_entry.c Outdated Show resolved Hide resolved
Copy link
Collaborator

@slabasan slabasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

Removes empty line at the end of the file.

Adds empty lines around material within #define/#endif
Adds line separating system and local #include statements.
Removes duplicate #include
Add separating line between system and local includes.
msr-smp.h Outdated Show resolved Hide resolved
Per Stephanie's comment.
@rountree
Copy link
Collaborator Author

@slabasan Let me know if you'd like me to squash all of these (or you can do it if you like).

@slabasan slabasan merged commit 465f56e into LLNL:main Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several missing-prototype warnings
3 participants