Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul of Distance Based Scoring Functions #177

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

Yejashi
Copy link
Collaborator

@Yejashi Yejashi commented Jun 14, 2024

Motivation

We discovered that the current implementation of Bhattacharyya and Hellinger scoring functions does not fully capture the intended behavior. These distance metrics only return a magnitude, providing no indication of the direction or preference in the comparison. As a result, it becomes unclear what the values represent in terms of scoring.

To address this, we've introduced functionality to assign a sign to the distance metrics. This allows the scoring functions to not only return the magnitude of the difference between two samples but also indicate a preference or direction through the signage. This enhancement gives users a clearer interpretation of the results.

Key Updates

  • Split Bhattacharyya and Hellinger Metrics: The Bhattacharyya and Hellinger distance metrics have been separated into individual functions for better modularity and maintainability.
  • Scoring Function Built on Top of Metrics: A new scoring functionality has been implemented to leverage these metrics, providing both the magnitude and the signage for improved decision-making.

@Yejashi Yejashi self-assigned this Jun 14, 2024
@Yejashi Yejashi added area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes status-work-in-progress PR is currently being worked on type-feature Requests for new features or PRs which implement new features labels Jun 14, 2024
@Yejashi Yejashi marked this pull request as draft June 14, 2024 23:27
@Yejashi Yejashi force-pushed the scoring_function branch 4 times, most recently from 30bb4f5 to dbb3a7f Compare June 20, 2024 21:13
@Yejashi Yejashi added status-ready-for-review This PR is ready to be reviewed by assigned reviewers and removed status-work-in-progress PR is currently being worked on labels Sep 9, 2024
@Yejashi Yejashi changed the title Per Node Threshold Based Recommendations Overhaul of Distance Based Scoring Functions Sep 9, 2024
@Yejashi Yejashi marked this pull request as ready for review September 9, 2024 16:34
@ilumsden ilumsden added priority-normal Normal priority issues and PRs area-stats Issues and PRs related to Thicket's stats subpackage and removed area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes labels Sep 9, 2024
@ilumsden ilumsden added this to the 2024.2.0 milestone Sep 9, 2024
@slabasan slabasan merged commit 2b9e450 into LLNL:develop Sep 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-stats Issues and PRs related to Thicket's stats subpackage priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants