Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confidence Interval Stats Function #213

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Confidence Interval Stats Function #213

merged 3 commits into from
Oct 25, 2024

Conversation

Yejashi
Copy link
Collaborator

@Yejashi Yejashi commented Oct 1, 2024 •
edited
Loading

This PR introduces a new functionality to calculate confidence intervals within a Thicket object. The added confidence_interval function enables users to assess the variability and uncertainty in the performance data across multiple runs, providing a statistical range within which the true performance metric is likely to fall with a specified level of confidence.

@Yejashi Yejashi added priority-normal Normal priority issues and PRs status-work-in-progress PR is currently being worked on type-feature Requests for new features or PRs which implement new features labels Oct 1, 2024
@Yejashi Yejashi self-assigned this Oct 1, 2024
@Yejashi Yejashi marked this pull request as draft October 1, 2024 18:52
@Yejashi Yejashi requested a review from ilumsden October 7, 2024 03:24
@Yejashi Yejashi marked this pull request as ready for review October 7, 2024 03:24
@Yejashi Yejashi requested a review from slabasan October 7, 2024 16:34
slabasan
slabasan reviewed Oct 14, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
ilumsden
ilumsden requested changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@ilumsden ilumsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Just a few tweaks that I think should be made. The biggest thing is adding a test case that actually confirms that the computations are correct, at least for a few nodes.

README.md Outdated Show resolved Hide resolved
thicket/stats/confidence_interval.py Outdated Show resolved Hide resolved
thicket/stats/confidence_interval.py Outdated Show resolved Hide resolved
thicket/stats/confidence_interval.py Show resolved Hide resolved
thicket/stats/confidence_interval.py Outdated Show resolved Hide resolved
thicket/stats/confidence_interval.py Outdated Show resolved Hide resolved
thicket/stats/confidence_interval.py Show resolved Hide resolved
thicket/stats/confidence_interval.py Show resolved Hide resolved
thicket/tests/test_stats.py Outdated Show resolved Hide resolved
@Yejashi Yejashi force-pushed the confidence_interval branch 3 times, most recently from 03800e5 to 909a18e Compare October 16, 2024 15:41
@Yejashi Yejashi added status-ready-for-review This PR is ready to be reviewed by assigned reviewers and removed status-work-in-progress PR is currently being worked on labels Oct 16, 2024
@ilumsden ilumsden linked an issue Oct 16, 2024 that may be closed by this pull request
Add a function for calculatung confidence interval #210
Closed
@slabasan slabasan added this to the 2024.2.1 milestone Oct 23, 2024
@slabasan slabasan merged commit 429b027 into LLNL:develop Oct 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slabasan slabasan slabasan approved these changes

@ilumsden ilumsden Awaiting requested review from ilumsden

Assignees

@Yejashi Yejashi

Labels
priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features
Projects
None yet
Milestone
2024.2.1
Development

Successfully merging this pull request may close these issues.

Add a function for calculatung confidence interval
3 participants
@Yejashi @slabasan @ilumsden