Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend metadata_column_to_perfdata to Multiple Columns #216

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Oct 22, 2024

Summary

Overdue improvements to the metadata_column_to_perfdata Function, mainly enabling adding multiple columns to the performance data table at the same time:

  1. Enable adding several metadata_columns with one function call.
  2. Rename to metadata_columns_to_perfdata to reflect functionality.
  3. Add join_key argument to enable the usage of a different key to join on.
  4. Improve the unit testing
  5. Add extra error check for presence of join_key

Example

develop

tk.metadata_column_to_perfdata("variant")
tk.metadata_column_to_perfdata("tuning")
tk.metadata_column_to_perfdata("problemsize")
tk.metadata_column_to_perfdata("num_procs")

#216

tk.metadata_columns_to_perfdata(["variant", "tuning", "problemsize", "num_procs"])

@michaelmckinsey1 michaelmckinsey1 self-assigned this Oct 22, 2024
@michaelmckinsey1 michaelmckinsey1 added area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features labels Oct 22, 2024
@michaelmckinsey1 michaelmckinsey1 changed the title metadata_column_to_perfdata Multiple Columns metadata_column_to_perfdata Extend to Multiple Columns Oct 22, 2024
@michaelmckinsey1 michaelmckinsey1 changed the title metadata_column_to_perfdata Extend to Multiple Columns Extend metadata_column_to_perfdata to Multiple Columns Oct 22, 2024
@slabasan slabasan merged commit 91d62d1 into LLNL:develop Oct 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants