-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Ensemble Functions & Change Ensemble APIs #61
Refactor Ensemble Functions & Change Ensemble APIs #61
Conversation
fef59e5
to
4f6d8b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks pretty good, just one small comment.
f18b8fa
to
a94c57c
Compare
@vanessalama09 This PR is making changes to the tutorial notebooks, but to the rendered ones in the thicket source. How would you like to get these changes over into the thicket-docs version? |
docs/thicket_tutorial.ipynb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes should be in thicket-tutorial, and then rendered here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to notebooks should be in thicket-tutorial, then rendered here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a94c57c
to
b005d8c
Compare
@michaelmckinsey1 Can you please rebase this branch on top of develop to fix the conflict? |
Thicket-docs are in thicket source. The rendered versions are the ones in docs. Did you mean over to thicket-tutorial? |
440a036
to
0e731d6
Compare
Summary
thicket.py
is becoming quite unwieldy so this refactor is in an effort to improve readability, maintainability and usability.Thicket.columnar_join
->Thicket.concat_thickets(axis="columns")
Thicket.unify_ensemble
->Thicket.concat_thickets(axis="index")
_unify
.We should consider doing something similar for the filter functions, etc.